Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5740 +/- ##
=======================================
Coverage 72.65% 72.65%
=======================================
Files 30 30
Lines 1682 1682
Branches 369 369
=======================================
Hits 1222 1222
Misses 397 397
Partials 63 63 Continue to review full report at Codecov.
|
jsjoeio
commented
Oct 31, 2022
jsjoeio
force-pushed
the
jsjoeio/csp-test
branch
from
66dfe33 to
b4a673b
Compare
jsjoeio
commented
Nov 3, 2022
Comment on lines
+19
to
+24
| // It's an iframe within an iframe | ||
| // so we have to do .frameLocator twice | ||
| const renderedText = await codeServerPage.page | ||
| .frameLocator("iframe.webview.ready") | ||
| .frameLocator("#active-frame") | ||
| .locator("text=Hello world") |
Contributor
Author
There was a problem hiding this comment.
This was the hardest part. I didn't realize it was an <iframe> inside of an <iframe> but some rubber-ducking with @code-asher helped me figure it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test to ensure webviews work by rendering the Markdown Preview.